Adding note on the use of the default * use in route authentication dependecies
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhealy1
requested changes
Jan 11, 2025
Co-authored-by: Jonathan Healy <[email protected]>
jonhealy1
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Using multiple authentication dependencies on a single route can cause clashes if not done correctly (merging them). This is particularly relevant to the default
*route. My pull request on stac-fastapi to dynamically merge multiple dependencies was rejected and I don't think it's possible to replicate it here. So I've added a note to the dependency documentation to try to explain what to do in this case.PR Checklist:
pre-commit run --all-files)make test)